-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Fullstory recording start conditions #50516
Conversation
@paultsimura @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
No need for C+ testing here. |
The lint error is:
This is not related to any changes I'm doing in this PR, and I'm not sure how changing those would impact the PR app. @AndrewGable should I implement those either way? |
Yes I think we are supposed to update any of them that are included in the files changed, is it a big change? |
Not huge: Lines 309 to 333 in e8c4fdc
|
I'd prefer to include it then just to follow our process |
src/Expensify.tsx
Outdated
@@ -149,7 +146,7 @@ function Expensify({ | |||
ActiveClientManager.init(); | |||
|
|||
// Initialize Fullstory lib | |||
FS.init(); | |||
FS.init(userMetadata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewGable We don't need to rerun useLayoutEffect
when userMetadata
changes since that will be updated through another flow. Will userMetadata be available inside useLayoutEffect
if it's not part of the dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is giving a warning:
155:8 warning React Hook useLayoutEffect has a missing dependency: 'userMetadata'. Either include it or remove the dependency array react-hooks/exhaustive-deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I believe it should be available still, however, this function will just be run once on initial render and that's it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, the next runs will happen when user_metadata key is updated. Added a linter disable here.
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
bump @AndrewGable, if we can try to merge this today it'd be great! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.0.50-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀
|
updateRequired: { | ||
key: ONYXKEYS.UPDATE_REQUIRED, | ||
initWithStoredValues: false, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieldoglas I think there's a very likely possibility this change has been leading to issues with the updateRequired
logic. The intended behavior is that this value will only be true
when it is explicitly set to true AFTER the component has mounted. If the value gets stuck on true
then the user will get stuck and be unable to upgrade since they'd be on the correct version already, but have out of date Onyx values.
@AndrewGable I think we should revert the |
Oh I see you can pass |
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/434803
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop